Order summary card using visual code studio

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace<div class="container">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  There is no need for <br> in the html.

  Give .container a background-color of white. For a responsive content, give .container a fixed max-width value. max-width:432px which is 27rem.

  To center .container on the page using flexbox or grid instead of position: absolute, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  USING FLEXBOX:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  USING GRID:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  The svg in the html should be a background image of the body with a background-size of contain and background-repeat of no-repeat. In the media query you have to change the background-image of the body.

  There is no need to give .container a box-shadow.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0
• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Good job on completing the challenge successfully!

  It looks like you are changing the text color instead of background color. So button:hover { background-color: your-color-of-choice} should do the trick. Also you can add cursor:pointer; to the button and even transition: all .4s ease; to button to make it change bg smoothly.

  Also i'd suggest removing the border from the card container. Keep it up!

  Hope you find this feedback helpful!

  0