Design comparison
SolutionDesign
Solution retrospective
This is my first challenge on the platform, comments are received
Community feedback
- @pikapikamartPosted about 3 years ago
Hey, really awesome work on this one. Also, congrats on the first challenge! The layout in general looks really great.
Some suggestions would be:
- For the vector-image , you should have used
alt=""
on it and addedaria-hidden="true"
attribute on theimg
, since the image is just decoration. Also, you don't need to usefigure
on it, since you are not really displaying an image that needs a caption. - I would use anchor tags
a
on theproceed to payment
andcancel order
since the component is not really a form where I can submit the data. But maybe on a real app, so maybe both could be used for now. ( I got confused about what I said haha).
Those 2 only. Again, great work on your first fem challenge.
2 - For the vector-image , you should have used
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord