Design comparison
Solution retrospective
Hey guys. Just finished this challenge and I would like to know if there are any ways I can improve. Thank you.
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi RavanCod, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- Every pages needs a
<h1>
to show which is the most important heading. So replace the<h2>
with<h1>
and follow the sequence h1-h5I noticed that at higher resolutions, the background image is broken, to fix this we can do the following:
As you used a
max-width
in the main tag, the right thing would be to use the images and background colors in the body:main { /* background-image: url(../images/pattern-background-desktop.svg); */ /* background-size: 100% 50vmin; */ /* background-repeat: repeat-x; */ /* background-color: var(--paleblue); */ margin: 0 auto; }
body { background-image: url(../images/pattern-background-desktop.svg); background-size: 100% 50vmin; background-repeat: repeat-x; background-color: var(--paleblue); }
The rest is great!!
Hope it helps...👍
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord