Order Summary Card using Grid and Flex Box

Community feedback

• 

  Janelle Schuh•90

  @jschuh23Posted over 2 years ago

  @missbaah Great job on the project!! I have yet to work on this one, but plan to jump into the challenge soon :)

  I noticed a few accessibility issues that were identified in the FEM report. Most of these should be easy fixes.

  • All page content must be contained by landmarks The rule description states - "it is best practice to contain all content excepting skip links, within distinct regions such as the header, nav, main, and footer." I would suggest that you either wrap your section class="container" in a main element or change this section element to a main element. That should fix 3 of your accessibility issues.
  • Page should contain a level one heading My suggestion here would be to change your current h2 to an h1 and then resize the h1 in your css. Finally, to follow semantic HTML I would change your div class="attribution" to a footer element.

  Again, great job on this challenge!!! Keep up the good work!

  Marked as helpful

  0

  ---

  

  Adwoa Baah Addo-Brako•30

  @missbaahPosted over 2 years ago

  @jschuh23 Thank you so much for the feedback !!!

  0