Janelle Schuh• 90
@jschuh23
Posted
@missbaah Great job on the project!! I have yet to work on this one, but plan to jump into the challenge soon :)
I noticed a few accessibility issues that were identified in the FEM report. Most of these should be easy fixes.
- All page content must be contained by landmarks
The rule description states - "it is best practice to contain all content excepting skip links, within distinct regions such as the
header
,nav
,main
, andfooter
." I would suggest that you either wrap yoursection class="container"
in amain
element or change thissection
element to amain
element. That should fix 3 of your accessibility issues. - Page should contain a level one heading
My suggestion here would be to change your current
h2
to anh1
and then resize theh1
in your css. Finally, to follow semantic HTML I would change yourdiv class="attribution"
to afooter
element.
Again, great job on this challenge!!! Keep up the good work!
Marked as helpful
0