Order summary card using flex

Community feedback

• 

  Yazdun•1,310

  @YazdunPosted about 3 years ago

  Hello and congrats on finishing your first challenge ! Here are my suggestions :

  • Use img tag instead of using svg itself in your html.
  • Give border-radius and then overflow:hidden to parent element instead of giving border-radius to the children.
  • I noticed you haven't used background image, You must use background-image on body
  • give transition to the element itself, not to the hover selector, By giving transition to element itself, It will remain smooth even on mouse leave !
  • give width:100% to the card and then max-width: 350px, so you make sure your design looks good on very small screens.

  ✅ Also I opened a pull request to your github repository which will fix some of these issues.

  I hope this helps !

  Marked as helpful

  0

  ---

  

  Nico Arifin•260

  @N1CoderPosted about 3 years ago

  @Yazdun Thank you so much for your suggestions, that will help me to improve my code.

  0