Design comparison
Solution retrospective
Hi All, Made this small project using SASS. Any feedback will be highly appreciated. Thanks & best regards.
Community feedback
- @FluffyKasPosted almost 3 years ago
Hiyo,
Your solution looks great! I have a few small suggestions only ^^
-
Reconsider your alt texts after reading this article.
-
For buttons, you need to set a font-family, otherwise they'll just use the browser's default.
-
"Cancel order" should be either a link or a button instead of a
p
. -
Setting your font sizes in px isn't a great idea, as they don't rescale if someone wanted to change their browser's default font-size. You used rem in other places so I'd suggest doing the same with font size too (or other relative units of your choice, really).
All in all, you did very good though ^^ Happy coding!
Marked as helpful0 -
- @GitHub-dev12345Posted almost 3 years ago
And Nice Coding & Good Work 🚀👍
Marked as helpful0 - @GitHub-dev12345Posted almost 3 years ago
Used for proper background image : 😊👌
In body tag used this CSS property: body{ background : url("./images/uesd image path") no-repeat; background position: top center; background size: 100% 50%; ( this is your choice check the image performance, and the gave the size percentage on your choice); this code very helpful for your background image😉😎 keep it up; }
I hope you find this helpful
Marked as helpful0 - @GitHub-dev12345Posted almost 3 years ago
Congratulation to complete the challenge ❤️👍 My small suggestion : 1.In Card design CSS Code Used this:
transform : scale(0.8); this property decrease the size of card. 😉
large size for increase the number of scale & small size for decrease the number of scale
I hope you find this helpful
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord