Design comparison
SolutionDesign
Community feedback
- @abhik-bPosted over 2 years ago
👋 Hello Chiamaka, Your solution is great & responsive enough . Good job 👍 I am just sharing some of my opinions that might make it look nicer.
- use
object-fit: cover;
to img to make the image look responsive & nice - in
card-container
instead ofwidth:30%
usemax-width:400px
(use value of your own choice) can make the card look nice & responsive for large screens.
Other than that your solution is nice , Well Done & please keep coding amazing solutions like this 😃👍
Marked as helpful1 - use
- @denieldenPosted over 2 years ago
Hi Chiamaka, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add descriptive text in the
alt
attribute of the image - To make it look as close to the design as possible set
width: 25rem;
to.card-container
class - remove all
margin
frombody
class because with flex they are superfluous - try to add a little
transition
on the element with hover effect - For add the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center; background-size: contain; background-color: #e0e8ff;
Overall you did well :)
Hope this help and happy coding!
Marked as helpful1 - add descriptive text in the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord