Design comparison
SolutionDesign
Solution retrospective
Feedback, tips, and best practices are most welcome.
Community feedback
- @denieldenPosted about 2 years ago
Hello Markhadi, You have done a good work! š
Some little tips to improve your code:
- image bg is broken, fix the url in
container
class like this:background-image: url("../images/pattern-background-desktop.svg")
.. not only with slash/
- add descriptive text in the
alt
attribute of the images - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - use
min-height: 100vh
to body instead ofheight
, otherwise the content is cut off when the browser height is less than the content - add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help š and Happy coding!
Marked as helpful0 - image bg is broken, fix the url in
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord