Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order summary card html and tailwind-css

@saifuldt

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

--------('-')---------

What challenges did you encounter, and how did you overcome them?

--------('-')---------

What specific areas of your project would you like help with?

--------('-')---------

Community feedback

T
Grace 29,310

@grace-snow

Posted

This overflows my screen and breaks very badly for users who use a different text size. It would also break if authors changed the text in any way.

The reason is a foundational and essential one: do not set explicit widths and heights on components. Let the browser do it's job and decide what height is needed based on the content of the card. Use max width (in rem) instead of width so the component can shrink narrower when it needs to.

Buttons and paragraphs should not have explicit widths either. In fact the only elememt that should have an explicit width is the music icon. The button should only be full width (100%).

The other important problem I note is around the use of alt text on images. This is not how to use it. I recommend you read the excellent post I the resources channel on discord about how and when to write alt text on images.

The last thing is more of a question for you to explain — why is change an anchor, proceed a button and cancel a button? That may be fine, but can you explain why you chose each one? (What you'd expect to happen on click)

0

T
Grace 29,310

@grace-snow

Posted

I've just had a quick look at your other solutions and it looks like you'll need to fix the same issues in previous projects. I'll add Screenshots to your discord post to demonstrate why limiting the height of elements that contain text is such a problem.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord