@0xabdulkhaliq
Posted
Hello there ๐. Congratulations on successfully completing the challenge! ๐
- I have other recommendations regarding your code that I believe will be of great interest to you.
BACKGROUND iMAGE ๐ธ:
- The
background-image
has not been properly set yet, they image seems to be disorted while the user tries to zoom-in or zoom-out the window. So let me explain How you can easily apply thebackground color
along with thesvg
they provided.
- Add the following style rule to your css, and then experience the changes
body {
background: url(./images/pattern-background-desktop.svg), #E1E9Ff;
background-repeat: no-repeat, no-repeat;
background-size: contain;
}
- Tip, Don't forget to generate a new screenshot after editing the
css
file
.
I hope you find this helpful ๐ Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
@Parviz-Parastar
Posted
@0xAbdulKhalid
Hello to the professional front end developer Mr. Abdul Khalid.๐
I am very glad that you have reviewed my solution and sent me a valuable suggestion. You are one of the always active and professional members of the frontend mentor site and I am very happy that I can use your experiences to improve.
Yes that's right.
I code background-size: contain;
I used it for the elements and boxes inside the Body, but I didn't know that I should apply this to the background as well.
And I had a small question that we must apply the second no-repeat
which is for the background-color
?
background-repeat: no-repeat, no-repeat;
Because I don't see any effect in writing or not writing for the background color.
Is it necessary to write?
I am waiting for your answer.
Thank you very much.๐๐งก