Design comparison
Solution retrospective
I'm open to receive any feedback, especially on responsiveness (with media queries) and best practices in general :)
Community feedback
- @vanzasetiaPosted over 2 years ago
Hello, Italo! 👋
Congratulations on finishing this challenge! 👏 Good effort on this challenge! 👍
About the responsiveness of this site, you might be able to finish this challenge with one media query. So, the only thing that needs a media query is the background image. The card only needs a
max-width
in order for it to be responsive (not awidth
). This way, card can become smaller if needed and limit the grow of it.It's recommended to write the styling using the mobile-first approach. It often leads to shorter and better performance code. Also, mobile users won't be required to process all of the desktop styles.
input
element should be used in theform
element so, I would recommend using thebutton
element. Also, make sure to specify thetype
of the button to prevent the button behave unexpectedly.I hope this helps! Keep up the good work! 👍
Marked as helpful1@itsguimPosted over 2 years ago@vanzasetia Thanks a lot for the feedback! I'll try to apply all of this in my future projects! Thank you again for your time o/
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord