Order summary card component using flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div id="mainBox"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Sekou Cissé•60

  @IsekkuPosted over 1 year ago

  @0xAbdulKhalid Hi, thank you for your really constructive comment, i didn't know that and i'll try to do this with my future works ! Thanks again :)

  0
• 

  Michelle Dela Rosa•180

  @mbdelarosaPosted over 1 year ago

  Hello and good job on the solution! Just wanted to provide further suggestions:

  • It is suggested to avoid using IDs as CSS selectors, and instead use classes for styling. This article from FED Mentor really helps explain why
  • It's also suggested to use rem instead of px for font sizing to make the design more accessible and responsive—this is mentioned on a separate article from FED Mentor

  Hope these are helpful! Best of luck!

  Marked as helpful

  0

  ---

  

  Sekou Cissé•60

  @IsekkuPosted over 1 year ago

  @mbdelarosa Hi, thank you for your tips, i'll try to do all you say with my future works :)

  1
• 

  Aimal Khan•2,260

  @Aimal-125Posted over 1 year ago

  In your CSS code, give body element height of 120 or 150vh by using media query with max-height: 400px; for screens with small heights so that your web app look good on small screens.

  1