@FluffyKas
Posted
Hey Jen,
The end result looks lovely, so I'm only here to give you a few small suggestions that you might want to keep in mind for future projects:
-
I'm sure you've heard this before: pixels aren't always the best choice of unit to use (in most cases, they aren't). There are mainly accessibility reasons behind this, if you have the time and interest, you can read about the topic in more detail here. Relative units (em, rem, etc) are a better alternative and rem is pretty easy to get started with, for example.
-
While using IDs isn't very harmful in a small component project like this one, when you work in larger, more complex projects it will come back to bite you in the butt :) When you work with any sort of CSS, it's always a good idea to keep reusability in mind, it will help you work faster and make your code more readable and concise. IDs, since they're always unique, go against this basic principle so it's the best to avoid them, unless you have a good reason to use them. Go with classes!
-
Background images are best added with CSS. You can just set them with the "background" property on the body (you can add multiple backgrounds even, comma separated, like a colour and an image) and then switch between the mobile and desktop version with media queries.
Marked as helpful
