Design comparison
SolutionDesign
Solution retrospective
Any feedback is welcome :)
Community feedback
- @vanzasetiaPosted over 2 years ago
Hello, Marcelo Vazquez Gutierrez! 👋
Congratulations on finishing another challenge! 👏
Some suggestions from me.
- Always specify the
type
of thebutton
. In this case, set the type of them astype="button"
. It will prevent the button from behaving unexpectedly (like submitting). - Create a custom
:focus-visible
styling for any interactive elements (button
, links,input
,textarea
). This will let people who use a keyboard to navigate the site know where they are currently on the page. - I suggest adding
rel="noopener"
to any anchor tags that havetarget="_blank"
. This is a security essential for external links. I suggest reading the web.dev article to learn more about this.
Hope this helps. 🙂
Marked as helpful0@Canti21Posted over 2 years agoHello.
Thank you for the advice. I'll be sure to keep it in mind for future projects :)
Peace ✌.
0 - Always specify the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord