Design comparison
SolutionDesign
Solution retrospective
- Hi every one i am vignesh a beginner to this coding world. this is my first challange in frontent mentor. please give your feedback for my solution.
- I face difficult to positioning this div child in proper order but i manage to do that.
- If you have better way to that please let me know thank you.
<div class="anual"> <svg class="svg" xmlns="http://www.w3.org/2000/svg" width="48" height="48"><g fill="none" fill-rule="evenodd"><circle cx="24" cy="24" r="24" fill="#DFE6FB"/><path fill="#717FA6" fill-rule="nonzero" d="M32.574 15.198a.81.81 0 00-.646-.19L20.581 16.63a.81.81 0 00-.696.803V26.934a3.232 3.232 0 00-1.632-.44A3.257 3.257 0 0015 29.747 3.257 3.257 0 0018.253 33a3.257 3.257 0 003.253-3.253v-8.37l9.726-1.39v5.327a3.232 3.232 0 00-1.631-.441 3.257 3.257 0 00-3.254 3.253 3.257 3.257 0 003.254 3.253 3.257 3.257 0 003.253-3.253V15.81a.81.81 0 00-.28-.613z"/></g></svg> <p class="p"> <strong>Annual Plan</strong></p><p style="margin-top: 26px; left:15px;" class="p">$59.99/year</p> <a class="a" href="">Change</a> </div>
Community feedback
- @Fola-JoePosted about 2 years ago
Congratulations on your first project here! 😎🎉🎉 So, a few things to consider - concerning the music icon, you could have just used
<img src="images/icon-music" alt="">
rather than the long svg tag you used. Also, try to avoid using inline CSS.You could solve the whole div issue using this:
<div class="price"> <div class="left-side"> <img src="images/icon-music" alt="music icon"> <div class="inner-left-side"> <h3>Annual Plan</h3> <p>$59.99/year</p> </div> </div> <a class="a" href="">Change</a> </div> .price { background-color: hsl(225, 100%, 98%); border-radius: 0.8rem; padding: 0.85rem; display: flex; justify-content: space-between; align-items: center; } .left-side { display: flex; align-items: center; } .inner-price-left { margin-left: 1rem; }
You can make adjustments to the values and more often, use rem or em instead of px. Of course, you can make use of your own class names 😄 I hope this helps, happy coding!😁🎈
Marked as helpful0@vigneshajithPosted about 2 years agoHi fellow coder i just finish my second challenge. check it out bro and thanks for the previous solution ☺☺☺
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord