Design comparison
SolutionDesign
Solution retrospective
Any Feedback or suggestions are welcome
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @Kaung-Thant-Kyaw!
Your solution looks great!
I have just one suggestion:
- You set
height: 85%;
to thearticle.order-container
and this is making your card overgrow vertically because its height is tied to its parent element (main).
š Since you set
height: 100vh
to yourmain
, it means that yourarticle.order-container
's height is always gonna be 85% of the vertical size of the screen.You can fix that just by removing this line (
height: 85%;
) from your code šI hope it helps!
Other than that, great job!
1@Kaung-Thant-KyawPosted 10 months agoThank you for your advice @danielmrz-dev
1 - You set
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord