Order Summary Card

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Brendan, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • img element must have an alt attribute, it's very important!
  • use classes not ids to stylize elements because the id must be unique in the html page and used for specific chunks, usually to have hooks on working with javascript
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the header tag container of image
  • remove all margin from container id
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • try to add a little transition on the element with hover effect
  • instead of using px try to use relative units of measurement -> read here

  For add the top image in the background just put more specific background properties to the body:

  background: url("../img/pattern-background-desktop.svg") no-repeat top center;
  background-size: contain;
  background-color: #e0e8ff;
  

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  1

  ---

  

  P

  Brendan Wilson•70

  @Brendan-A-WilsonPosted over 2 years ago

  Thanks @denielden. This was very helpful. I'll look to make these changes and re-upload the project again.

  1