Order summary card

Community feedback

• 

  raya•2,870

  @rayaattaPosted 11 months ago

  👋hello Kavman-Ski, congratulations on completing this challenge 🎉 I have some suggestions you might find interesting. Semantic suggestions 1.You should replace the <article class="contain"> with <main class="contain"> The article would have been good for a larger website with multiple components but in this case it is the only component so it is the main page content. 2.You may then use article to replace <div class="para"> for better accessibility as divs have no semantic value. 3.you should also replace <div class="attribution"> with <footer class= "attribution"> Styling suggestions 1.it is much more recommended that you put a link to you fonts inside your html. 2.you should change height:100vh;on the body to min-height:100vh; This will ensure that your layout doesn't break on shorter screens or mobile devices in landscape mode.

  I hope this helps Other than that your solution is great 👏. Happy coding 🙃

  Marked as helpful

  1

  ---

  

  Kavman-skl•70

  @Kavman-sklPosted 11 months ago

  @rayaatta I really appreciate the tip

  0

  

  raya•2,870

  @rayaattaPosted 11 months ago

  I'm always happy to help@Kavman-skl

  0