Design comparison
SolutionDesign
Community feedback
- @adityas24Posted almost 3 years ago
Hey Abdur great Job!
Very well written markup and very well use of BEM. Now learn about em and rem and start using them. You are ready to rock.
All the best 🙂👍
Marked as helpful0@abdurakhmon-webPosted almost 3 years ago@adityas24 Thank you very much.
Yes of course but px is more convenient for me.
0 - @RioCantrePosted almost 3 years ago
Hello there! Awesome work with this project. Looking at your solution, you did well on implementing the design and I think you should considered the following as well...
- Add the background image in the
body
tag with properties ofbackground-position: top
,background-repeat: no-repeat
andbackground-size:cover
. Add media query and replace the background image for mobile - Use specific tag to wrap the content, instead of
div
wrap thecontainer
withmain
tag for readability
Hope this helps and Keep up the good work!
Marked as helpful0@abdurakhmon-webPosted almost 3 years ago@RioCantre Thank you very much for your advice
1 - Add the background image in the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord