Design comparison
Solution retrospective
Started this Today. Now it's done. Check it Out.
PS: Was in the Zone. It was awesome!!!
All Feedbacks are WELCOMED
Community feedback
- @VCaramesPosted about 2 years ago
Hey @GiDDeRo, some suggestions to improve you code:
The Section Element is being used incorrectly, it would NEVER wrap a lone image with no heading.
-
the Article Element should wrap the entire card , not just the text content.
-
For your heading you always start with <h1> Heading. If there were other headings or other cards in this page, then you would use the <h2> Heading.
-
Your use of Alt Tag description in your main image needs to be improved. you want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.
-
The music icon needs to have an Alt Tag that is blank since it is decorative.
-
Your "button" was created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.
-
Your CSS Reset is extremely bare. You want to add more to it.
Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
Happy Coding!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord