Order summary card

Community feedback

• 

  Eugenia•950

  @JaneMorozPosted about 2 years ago

  Hey there 👋 Love you solution ❤️

  The only thing I've noticed:

  • Inline styles are considered "bad practice", so it's better to remove (height and width) from <img> tag and add width to style.css:

  article img {
    width: 100%;
    border-top-left-radius: 15px;
    border-top-right-radius: 15px;
  }
  

  Keep it up! And good luck 🍀

  Marked as helpful

  1

  ---

  

  cdr-in•90

  @cdr-inPosted about 2 years ago

  @JaneMoroz Thank you so much for the advice!

  1

  

  yishak abrham•2,150

  @yishak621Posted about 2 years ago

  @cdr-in you also didn't correctly work for mobile version

  0

  

  cdr-in•90

  @cdr-inPosted about 2 years ago

  @yishak621 I know I did not. I didn’t learn to make a responsive web for mobile yet. I’m focusing on mastering html and css strictly for pc websites. After that, I’m going to make them all responsive for mobile too.

  0

  

  cdr-in•90

  @cdr-inPosted about 2 years ago

  @yishak621 It should be mobile responsive now.

  1

  

  Eugenia•950

  @JaneMorozPosted about 2 years ago

  @cdr-in Awesome!

  0

  

  yishak abrham•2,150

  @yishak621Posted about 2 years ago

  @cdr-in it is very easy to make responsive all u have to do is to write a Media query for different screen sizes in general mostly for pc,for tabs and mobile versions.for example if you start ur css by designing for pc then you should target a media query for mobile versions ...for example if u have a box with a size of 10rem width and 10rem height then displaying it to small screens will be ugly design so all u have to do is decreasing the size so u can write it like these max-width 800px means that for screens <800px (mobile version) @media screen (max-width:800px){ .box{ width:5rem; height:5rem; } }

  0

  

  yishak abrham•2,150

  @yishak621Posted about 2 years ago

  @cdr-in it is very easy to make responsive all u have to do is to write a Media query for different screen sizes in general mostly for pc,for tabs and mobile versions.for example if you start ur css by designing for pc then you should target a media query for mobile versions ...for example if u have a box with a size of 10rem width and 10rem height then displaying it to small screens will be ugly design so all u have to do is decreasing the size so u can write it like these max-width 800px means that for screens <800px (mobile version) @media screen (max-width:800px){ .box{ width:5rem; height:5rem; } }

  0
• 

  yishak abrham•2,150

  @yishak621Posted about 2 years ago

  Awesome design and also the svg background must be   body {     background-color: url(images/pattern-background-mobile.svg) no-repeat;   } try these it shouldn't repeat itself

  0