@denissejoyce
Posted
Hey Guilherme, good job on completing the challenge 🎉
I have a couple of suggestions for you for your next project—
-
When we finally deploy our projects online, one other thing that we want it to be is SEO-friendly; to achieve this, it would be helpful to store your CSS styles in another file instead so that your HTML file is easier to read for search engines
-
As for the alignment of your card, I see that it can be 'more' vertically centered, you can do this by adding
min-height: 100vh
to your flex container/flex parent element (this sets the flex container's minimum height into 100% of the viewport) -
For your future projects, I also recommend you implement a mobile-first approach when setting your CSS rules (mobile designs tend to be simpler compared to desktop designs which makes it easier to start here); I see in your README file that you are familiar with Kevin Powell so I suggest this helpful read from him about the use of mobile-first approach!
(I am not very well-versed with SVGs so I do not have any feedback about it)
Marked as helpful
@denissejoyce What a feedback!! I Really appreciate it!! Regarding the separate CSS file, I know that working this way is better for search engines, but since it was my first challenge I didn't know if I could upload two separate files here, that's why I did it inside the html. Anyways, I just corrected it. Now you can find "index.html" and "styles.css". About vh and mobile-first (kevin powell), that really helped and I'll study more about the subjects.
Thank you, Denisse!!
@denissejoyce
Posted
@dz03vc great glad to be of help!!! 😊