@rayaatta
Posted
Hello 👋Layan-khalil, congratulations on completing another challenge 🎉
I have some suggestions you might find useful.
1
Try to make your html more Semantic by wrapping the main page content inside a <main> tag .
Replace
<div id="container">
With
<main id="container">.
This changes nothing visually but
Using it makes all the difference.
Using semantic markup improves
SEO
And user experience (accessibility) for people using assistive technology such as screen readers.
2
I noticed that you used <h2>Order Summary</h2> .since it is the only heading in the document you should replace it with <h1>.
Here's a quick guide on how to use them:
The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on.
You can then style them in you css.
Unlike what most people think, it's not just about the size and weight of the text It is about maintaining a clear and consistent hierarchy through out the document
3
I noticed <a href="#">Cancel Order</a>.
Since cancel order is intuitively not supposed to be a link. A better element would have been button
4
I noticed font-size:16px; in your css.
You should never use pixels when setting font related properties.
Setting font sizes in pixels causes accessibility problems with people who adjusted their default font sizes on their computers.
The best units for setting font size are relative units such as rem and em which can adjust with the user preferences. Checkout this article why font size should never be in pixels
I hope this helps 🙃
Otherwise your solution is neat👍
Happy coding ✌️
Marked as helpful
