Order Summary

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hey there,

  good work!

  I'd suggest to avoid giving fixed height or max-heights for elements/containers that contain text elements. It will cause accessibility issue, when user changes their default font-size, text will.

  But in this case, i cannot see the top part of the card and the bottom part seems to be touching the bottom edge of my screen on notebook (1280px 690px viewport), resulting in data loss. So you might consider making the whole card a bit more flexible and also add some spaces(padding/margin) to the edges of the page so card does not touch it.

  Hope you find this feedback helpful!

  Marked as helpful

  0

  ---

  

  iamis15•70

  @iamis15Posted over 1 year ago

  @visualdenniss Thanks for the feedback! It's greatly appreciated

  0
• 

  Gurditt Singh Khurana•10

  @gurdittcancodePosted over 1 year ago

  Hi, I think overall your project looks great. I would suggest that you add transition effects on hover etc, it would make your project look even better and smoother✌️

  1

  ---

  

  iamis15•70

  @iamis15Posted over 1 year ago

  @gurdittcancode Definitely! I'm in the midsts of learning animation but hopefully i will be able to do it soon.

  1
• 

  Akhil-Nagpal•180

  @Akhil-NagpalPosted over 1 year ago

  Hi there! 👋 Congratulations on completing this challenge! 🎊

  You did awesome work! Well Done! 👌

  I've some suggestions :

  • Always follow a structure. The <h1> to <h6> element tags must be in descending order(as per size). Read more 👉 The HTML Section Heading elements.
  • While using sections, you need to add headings on every section. So, you should change <section> into <div> or add headings to every section.

  Otherwise! Your solution is nearly perfect! 👏

  I hope you will find this useful! 😊 Happy Coding!

  0