Design comparison
Community feedback
- @Bayoumi-devPosted over 2 years ago
Hey Jason, It looks good!... You have
accessibility issues
that need to fix.Document should have one main landmark
, Contain the component with<main>
.
<main> <div class="main-container"> //... </div > </main>
-
Page should contain a level-one heading
, Changeh2
toh1
You should always have oneh1
per page of the document... in this challenge, you will useh1
just to avoid theaccessibility issue
that appears in the challenge report... but don't useh1
on small components<h1>
should represent the main heading for the whole page, and for the best practice use only one<h1>
per page. -
Heading levels should only increase by one
, Useh2
instead ofh4
...Ordered headings
make it easier to navigate and understand when using assistive technologies. -
I suggest you add
cursor: pointer;
tobuttons
, The cursor indicates to users there is an action that will be executed when clicking on it.
I hope this is useful to you... Keep coding👍
0@jsngmbPosted over 2 years agoHi @Bayoumi-dev I really appreciate your willingness to help me. Thank you so much.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord