Design comparison
SolutionDesign
Solution retrospective
Hi, my name is Jefferson, I'm Brazilian, I'm starting in the front-end world, I hope you like the result. Any feedback is welcome! =)
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @FrontalAce21 👋🏻
I have a quick tip to help you fix the accessibility issues and background image.
img
tags in your code are missingalt=""
, if there's nothing specific you can just put the name of the image. However, for this icon<img class="logo" src="./images/icon-music.svg">
you should addaria hidden="true"
because it's merely for decoration. You can read more about it here.- In order to fix the background, just add these couple of lines in body:
// FOR MOBILE body { background-image: url("./images/pattern-background-mobile.svg"); background-size: contain; background-repeat: no-repeat; background-color: #e0e8ff; }
and for desktop just change the link to desktop, like this ./images/pattern-background-desktop.svg
I hope this was helpful 👨🏻💻 you did a great job for your second project. Cheers 👾
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord