Design comparison
Solution retrospective
Hi .. I need you feedback's please!
Community feedback
- @jucajulian0907Posted over 2 years ago
Héctor, que tal?
La solución desafío quedo excelente, felicidades!
Talvez un cambio que yo le haría es colocar una propiedad background-repeat: no-repeat y un background-color del color que corresponda en el body para que quede igual al ejemplo. Es algo pequeño el cambio pero se va a ver mas bonito. Abrazo!
Marked as helpful0@hectorjbdPosted over 2 years ago@jucajulian0907 Graciasss, eso hare. Un abrazo para ti tambien
0 - @IlesanmieaPosted over 2 years ago
Hello Hector, you have done well having attempting this challenge. Cheers!
But there are few things I'd like to say to help you get better with time. I opened your site to review it for our betterment.
-
Try to use fancy name when hosting your challenge on any hosting platforms like Netlify,Vercel or GitHub Pages. Instead of using https://bespoke-ganache-fd66fc.netlify.app/ you could rename the site under site settings into something suitable in Netlify Dashboard to related name to your proposed site that's available. For Instance, for this particular project you could use a related name to the projects like https://ordercard.netlify.app, https://orderbox.netlify.app, https://ordersum.netlify.app etc which makes your custom domain name more meaningful when sharing with friends and also makes you sound professional when a recruiter is trying to go through your portfolio. I believe you may love it too.
-
For screen readers i.e accessibility purpose and Search Engine Optimization try to stick using HTML5 Semantics like you made use of
<p class="change">Change</p>
instead use<a class="change">Change</a>
which will render it clickable as orginial designs implies.
Hector, you have tried your best but we can improve with time,consistency,hardwork and importantly God's help. Kindly, let me know if my feedbacks are helpful by your reply and also clicking the helpful button
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord