Order Sumary

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Jean! 👋

  Congratulations on finishing this challenge! 🎉

  It looks like you have fixed the issue yourself, the background-image is showing up on my end. Good job! 👍

  I have some feedback on this solution:

  • Accessibility
    • Good job on using main landmark! 👍
    • The attribution should be lived inside the footer landmark.
    • Well done on leaving the alt empty for the hero illustration! 👏
    • For decorative SVGs, add aria-hidden="true" attribute to the svg. Also, remove the xmlns attribute from the <svg> tag, it's unnecessary to be there. 🙂

  <svg aria-hidden="true">
  </svg>
  

  • Always wrap text content with a meaningful element (p). Only use div and span for styling purposes.
  • <span class="cancel">Cancel Order</span>, the Cancel Order should also be an interactive element (button or a).
  • Always specify the type of the button. In this case, set the type of them as type="button". It's going to prevent the button from behaving unexpectedly (like submitting).
  • Change the body font size instead of the html font size. The root or html font size should be controlled by the user through the browser settings.
  • Use rem or sometimes em unit instead of px. Using px will not allow the users to control the size of the page based on their needs.
  • Styling
    • Don't limit the height of the body element, it will not allow the users to scroll the page if the page content needs more height. Set min-height: 100vh; instead.
    • Let the element inside the card element control or dictate the height of the card.

  One thing that will help people to review your CSS code is to have one CSS file that contains the full CSS code. It's also recommended to implement it in your project, since having one CSS file will boost the speed loading of your website.

  I hope you find this information helpful! Happy coding! 😁

  Marked as helpful

  1
• 

  Sonu Swapan Dutta•530

  @Sonu-DuttaPosted over 2 years ago

  Well done ! Absolutely perfect 💯

  1
• 

  Hexer•3,660

  @EmmanuelHexerPosted over 2 years ago

  Great job man. Keep it up

  0