Design comparison
Solution retrospective
What did you find difficult while building the project? Creating the annual Plan to be side to side.
Which areas of your code are you unsure of? Media queries.
Do you have any questions about best practices? if you have any tips or advise i will be happy to hear :)
Community feedback
- @johnphillipsdevPosted over 1 year ago
Hello Augousto Faggion,
Congratulations on completing your project! I noticed that your buttons have the default styling provided by the browser. You might want to check out some style reset guides online to remove any unexpected defaults. This can be particularly useful when starting new projects. Here are some resources to get you started:
I also noticed that you could complete your project without using many media queries. You can simply add a
max-width
property to your card element to prevent it from expanding too far. Here's a link to the documentation formax-width
:Additionally, you can center your card by giving the wrapping container, in this case the body, a class of
display: grid
andplace-items: center
. This should center your card nicely for your next preview screenshot. Just remember to set a minimum height of your body to100vh
to ensure that the container fills the entire screen. Here's some documentation on these CSS properties:I hope you find these resources helpful! Let me know if you have any questions. - Happy Coding!
1@augustofaggionPosted over 1 year ago@devmanjohn
thank you, i will read this resource and also apply in practice, i apreciate your help
1 - @peanutbutterjllyPosted over 1 year ago
hey 👋,
I noticed on big monitors that the card goes wider than the image is and its because you set the width of the .container div to be 37%.
if you set that to a fixed pixel value (like 378px) then the card stretch to be wider than the image.
Good job completing the solution!
1@augustofaggionPosted over 1 year ago@peanutbutterjlly Thank you , it is very helpful your advice i will corrected and update on github.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord