Order component version 1

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Krishna, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • To fix the top image in the background just put more specific background properties to the body:

  background: url("../img/pattern-background-desktop.svg") no-repeat top center;
  background-size: contain;
  background-color: #e0e8ff;
  

  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  Marked as helpful

  1

  ---

  

  Krishna Tiwari•80

  @krishna-cyberPosted about 2 years ago

  @denielden Hello deniel,💖Iam so happy to you, I have done some changes on my code 💻, according to your suggestions. It seems very helpful 👌 and clearcut code and pattern ... can you check once my code again and kindly please give some tips for optimizing my code😊😊 I am learning now. Some of the changes i have done in my code: 👌Remove an unnecessary div that wraps img tag 👌Remove an unnecessary div at pricing section 👌Background style changed as you mentioned me above

  and IT WORKS FINE NOW.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @krishna-cyber Sure, now is much better !! You are welmone and keep it up :)

  Marked as helpful

  1

  

  Krishna Tiwari•80

  @krishna-cyberPosted about 2 years ago

  @denielden Thanks a lot .... very helpfun and kind person 😍

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @krishna-cyber Thanks you too :)

  Marked as helpful

  1

  

  Krishna Tiwari•80

  @krishna-cyberPosted about 2 years ago

  @denielden have you watched my another solution tooo ..."product review card".... waiting for you feedback

  0