Design comparison
SolutionDesign
Community feedback
- @deepak-parmarPosted over 2 years ago
@kaminskimaciej, visually your works looks great!
First of all, you need to renew the screenshot and regenerate the report of your submission.
After then, you just have to eliminate some of the accessibility issues...
- Heading elements should always be used in order from
h1-h6
. For your.title
element useh1
tag instead ofh2
, it won't change anything in the design. - The same error is also caused by the
h5
tag later in your code. I suggest not usingh5
and use<p>
tag for it, since it is more like a label than a header. - Next, you need to wrap your whole
.container
element inside the landmark tag<main>
, cause all pages must have a landmark element.
You code looks decently clean, I suggest using some code formatter to automate that part.
I hope this clears up the issues. 👍
0 - Heading elements should always be used in order from
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord