Order component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Rubèn, You have done a good work! 😁

  Some little tips to improve your code:

  • To fix the top image in the background just put more specific background properties to the body:

  background: url("../img/pattern-background-desktop.svg") no-repeat top center;
  background-size: contain;
  background-color: #e0e8ff;
  

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  0

  ---

  

  Rubén Alvarado Orozco•210

  @rubenaoPosted almost 2 years ago

  @denielden thanks for the feedback! 😁

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @rubenao you are welcome and keep it up :)

  0