Order Comformation using Flex and Grid

Community feedback

• 

  César Mejias•190

  @CesarGMEFAPosted about 3 years ago

  Good sibling code, you could place the .attribution inside the main so that it doesn't overflow on top of the card and add a margin-top to it. For instance.

  The other thing is that you can put a link to your name in the attribution.

  The other thing you could accommodate is the width in the .card-container in the @media. It's at 330px and the size of an iphone 5 would be 320px, so it looks weird.

  I do those things and send you the proposed changes on github. and check the size of the box because in the body you put a height of 100vh and it still produces a horizontal scroll.

  Marked as helpful

  1
• 

  Nguyen Duy•245

  @koalalikecodePosted about 3 years ago

  Great work, so close to design. But you should use your h tag respectively h1>h2>h3...

  Marked as helpful

  1