Order card finish project

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Marcin, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • for add the top image in the background just put more specific background properties to the body:

  background: url("../img/pattern-background-desktop.svg") no-repeat top center;
  background-size: contain;
  background-color: #e0e8ff;
  

  • image is broken because link is wrong, fix it like this: ./images/illustration-hero.svg
  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the image
  • remove all margin from box class because with flex they are superfluous
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  Marked as helpful

  0

  ---

  

  Marcin Garski•350

  @margsoftbfPosted over 2 years ago

  @denielden Thanks for the feedback, i will be try check and change everything about you tell me. Thanks for your time.

  1
• 

  Martin Kamír•490

  @Martin-K-KamirPosted over 2 years ago

  Hey, i just check your code little bit.

  Couple things to look after.

  1. On the box class you do not need to use grid. What i would do is just set it to flex column and center it.

  2. The logo do not appear. You added bad pathway for the img. Also all the properties are not necessarily mostly the absolute position. Next time just add width to 100% and it will fill up the whole space in that box.

  3. The mobile__bg and desktop__bg is not correct way how to add that background image. For example add to body the background color and then background image with url to that image.

  4. Remember the buttons do not inherit from the body font-family.

  Anyway if this is your first project i think it is pretty good job.

  Marked as helpful

  0

  ---

  

  Marcin Garski•350

  @margsoftbfPosted over 2 years ago

  @Martin-K-Kamir Thanks for the feedback, i will be try check and change everything about you tell me. Thanks for your time.

  0