Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order Card Component solution using HTML and CSS

Promise 100

@Promise30

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I just completed this new challenge and I would love to hear reviews about the solution I was able to come up with and what I can improve on going forward.

Community feedback

@zenab12

Posted

Hey Promise You did amazing work congratulations for completing this challenge

-- to fix accessibility issues :

  • use <main</main> and wrap inside it <div class="container"></div> so all page content should be contained by landmarks.

-- To make your code more Responsive

  • don't give section or div specific height that will damage the responsivity in mobile if width of screen small so remove height and use min-height instead .

  • use <a href="#"> cancel order</a> instead <p>cancel order </p> to make it more semantic

  • you can use variables in css and save colors or fixed sizes in variables like this :

:root 
{
--main-color:#3829e0;
--font-family:'Red Hat Display',sans-serif;
}

h1 
{
font-family:var(--font-family)/*to call  value of the variable*/
}
  • you can comment footer section in this challenge to get more awesome view

You used semantic class names and id so code is readable and this awesome

Regardless You did amazing I hope this is useful to you... Keep coding👍

Marked as helpful

0

Promise 100

@Promise30

Posted

@zenab12 Thank you very much for this feedback. I'll take note of all that you mentioned and make the necessary changes and also implement them in my future projects.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord