only HTML ,CSS

Community feedback

• 

  Aakash Verma•6,710

  @skyv26Posted almost 3 years ago

  Hi! Armin, uffff!!! Exactly you felt same when you complete this. Dude, you did good but there are some many issues that I found and are listed below:

  1. Your design is not screen adaptive/ screen responsive as I opened it on my laptop and I saw it takes only 70% of width. There is lot of space at left and right side and it should need to fix.

  2. Image is not centered properly,

  Reasons i. you did not gave width to 100% and you added padding-left: 200px change your code with below snippet and it will work.

  .img-top {
      display: inline-block;
      /* text-align: center; */
      /* padding-left: 200px; */
      width: 100%;
      margin: auto;
  }
  

  you are using img tag so no need to add text-align property

  2. I find that you used padding: 5% 14% which is pretty main cause of your design not taking full width . just remove 14% because padding short hand property is padding: top-bottom left-right so according to your css rule added 14% at left and right side.

  3. Set your curved svg with 100% width it will take full screen width.

  4. There is no sufficient space between your input block and button in footer.

  5. Your design is not responsive, make it responsive so that design touch and feel always consitent to all kind of screen.

  There are lots of other problems too and all needs to be fixed ASAP.

  I hope you understand and I am not criticizing your work, I appreciate you hard work but I am helping you to be good frontend developer, I am also learning and maybe someone give you more better feedback than me.

  Good Luck

  1

  ---

  

  Armin Babic•40

  @ArminBabicPosted almost 3 years ago

  @skyv26 my bro <3 tnx for our time to check my first frontend mentor challange,yeah i need expirience and pratice and every feedback is more then welcome,tnx once again,i work on pc and my monitor is very big as well challange is to make it on desktop and mobile responsive and i think i did it but on laptop i know that will be issue,i know when i check it,but your advice its really helpfull i will try sort it asap...tnx

  1

  

  Aakash Verma•6,710

  @skyv26Posted almost 3 years ago

  @ArminBabic Your most welcome bro.

  0