Skip to content
Submitted over 1 year ago

only HTML and CSS with @media

yanal abu alrob•160
@Y-aburob
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

that was easy :D

Community feedback

  • _nehal💎•6,710
    @NehalSahu8055Posted over 1 year ago

    Hello Coder 👋.

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    • Remove margin from .qr as it will not dynamically center the card.

    • To properly center the card

    • USING FLEXBOX

    body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}

    • Every site must have one h1 element describing the main content of the page.

    • So, Add a level-one heading instead of p to improve accessibility.

    • <h1>Improve you frontend skills by building projects</h1>

    • Use Semantics for the proper design of your code.

    <body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
wrap up `.attribtution` div inside your footer.
</body>

    • For non-decorative images give meaningful and descriptive alt like alt= "QR code to frontend mentor website".

    • Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

    • Replace width with max-width to make your card more responsive.

    link.

    I hope you find this helpful.

    Happy coding😄

    Marked as helpful
    0
    yanal abu alrob•160
    @Y-aburobPosted over 1 year ago

    Thank You So Much For Your Help I Really Appreciate It. :) @NehalSahu8055

    1
  • Vlad•240
    @vladmeePosted over 1 year ago

    Neat!

    One small thing! On mobile, you are forcing a fixed height on the image:

    .qr img {
height: 300px;
}

    While the width is still in percentage:

    .qr img {
width: 95%;
...
}

    This skews the image a bit. Make sure you maintain its ratio across all resolutions. Either with fixed pixel values or you can experiment with vw/vh.

    Other than that everything is excellent. I feel from you that you got a good understanding of how to properly structure your CSS. Keep it up!

    Marked as helpful
    0
    yanal abu alrob•160
    @Y-aburobPosted over 1 year ago

    thank you so much for your help! :) @vladmee

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord