Design comparison
SolutionDesign
Solution retrospective
This is my first challenge in frontend mentor. Any feedback would be appreciated.
Community feedback
- @Smita-14Posted over 3 years ago
Hey Chandima! Congrats on your first awesome submission. It is nicely done. You could increase size of texts and buttons as they look smaller than in the design. Also I noticed that you have accessibility issues to address. You can do the following to fix them:
- Landmark issue - Wrap the whole body using semantic html element such as main, section, article etc. and try to use semantic html instead of div wherever possible.
Example
<body> <main class="container"> . . . </main> <section class="attribution"> . . . </section> </body>
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord