@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- Use semantic elements such as
<main>
and<footer>
to improve accessibility and organization of your page.
-
Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute. Thealt
attribute should explain its purpose. e.g.QR code to frontendmentor.io
-
Use
min-height: 100vh
instead ofheight
. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@FilipSzkarlat
Posted
Hi @MelvinAguilar,
Thanks for your suggestions. I have already updated the project code and I will definitely remember about them in future projects :)
Greetings!