Omelette recipe page using html and CSS

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted about 2 months ago

  Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…

  • Your heading elements <h1><h3><h2>, Heading elements should be in sequentially-descending order (e.g., <h1>, <h2>, <h3>) to create a clear content structure, improving accessibility and SEO. Skipping levels or using them out of order can confuse screen readers, affect search engine rankings, and make your content harder to understand.

              <h1>Simple Omelette Recipe</h1>
                  <h3>Preparation Time</h3>
                  <h2>Ingredients</h2>
  

  • While px is useful for precise, fixed sizing, such as border-width, border-radius, inline-padding, and <img> sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, using px for font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units like rem and adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Use px where exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel.

  • I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,

  • Line height is usually unitless to scale proportionally with the font size, keeping text readable across different devices. Best practice is to use a unitless value like 1.5 for flexibility. Avoid using fixed units like px or %, as they don't adapt well to changes in font size or layout.

  I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻

  0
• 

  ramiadi•50

  @ramiadiPosted about 2 months ago

  Nice code you got there. There is still improvements you can do. The first one is up to you. I personally make a folder and put my css in there for styling. This is because the html file can be alot of lines making it harder to see and understand. The second is i see you are using alot of pixels on everything. I recommend you to use rem or em when you use padding and margins because it makes the website more responsive. Lastly i want to point out is when you make the width of your website smaller, the box doesnt react to that well. the elements are almost hidden. Maybe try min-width:100vw;

  Anyways a good structure! I like your layout. I see you are using few divs and this is a good practise! The less is better. I want to point out its unique method of using article, i sure didnt use it. By the way nice table you made. Keep it up!

  0