Skip to content
Submitted over 2 years ago

OH LORD!!! It's Javascript time! 0_0 Flexbox makes an appearance too!

Gareth•410
@Gareth-Moore
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Base Apparel coming soon page
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Thanks for checking out my project.

I had a bit of an issue with <form> and inputs and all that. I was learning everything as I went along. I'd be very interested in feedback related to my form submit process.

Also the hero image that had to swap from mobile to desktop gave me a headache in the beginning. I am not sure if my solution is optimal or "correct" or even moral in the eyes of the lord. But any help there would be appreciated too.

Thanks a ton, Gareth

Community feedback

  • Vanza Setia•27,775
    @vanzasetiaPosted over 2 years ago

    Hi, Gareth! 👋

    Congratulations on completing this challenge! 🎉

    Some suggestions from me.

    • The navigation links are on the top of the page content. I would not recommend setting it as position: absolute. I would recommend making the navigation as an attribution instead. Also, put the attribution below the main element. Doing this will make the page structure better.
    • For the validation, I prefer making the form element listen to the submit event. After that, run the validation. 😅
    • For the hero image, you can try using grid to align the layout. Also, if you decide to use grid, I would recommend using the picture element to change the image based on the user viewport width.

    That's it! Hope these suggestions help! 😁

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord