Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Officelite coming soon site { HTML - CSS - VANILLA JS }

@FelipeCastroDEV

Desktop design screenshot for the Officelite coming soon site coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback ?

Community feedback

Vanza Setia 27,795

@vanzasetia

Posted

Hi, Felipe Amorim! 👋

Here are a few ways you can do to improve this solution.

  • Improve the alternative text of the logo by telling the destination of the link. You can improve it to "Home - Officelite".
  • Remove the aria-labelledby from the <section>. You don't need to do that unless the section needs to stand out for reasons. Otherwise, it may create unnecessary noises for screen reader users.
  • On the home page, "Coming 4 April 2023" should be <h2> instead of being a sub-heading of the previous section—"Ultimate" title.
  • On the signup page, that should also be <h2>. Don’t skip heading levels. In other words, heading levels must always be in order to give structure to a page.
  • Don't use @import. It can have a negative impact on page loading speed. The reason is using @import to import other stylesheets will cause the browsers to make other requests inside the CSS. So, instead of downloading one stylesheet, then executing the CSS and done, with @import the browsers have to download other stylesheets inside the stylesheet.
  • Also, it makes people harder to review your CSS since they have to open multiple tabs to review each of your stylesheets.
  • More information about CSS performance — CSS and Network Performance
  • You should use const or let for all variables instead of using var.
  • Grab the form element and make it listens to "submit" event. After that, run the validation. I recommend doing that instead of running the validation based on the button's click event.
  • <input> must have an accessible name or label. You can use aria-label attribute to label each input element.
  • Specify the type of the "Get on the list" button.

I hope this helps. Happy coding! 😄

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord