Design comparison
SolutionDesign
Solution retrospective
Hello everybody,
I present to you my solution for this challenge.
Any feedback is welcome and very appreciated ! 😊
Community feedback
- @vanzasetiaPosted about 2 years ago
Hello, Alain! 👋
Congratulations on finishing this challenge! 👏
Here are some recommendations for improvements.
- I notice that the alternative text for the logo is "redirect to home page". It's good that you use the alternative text to tell that it is a link. It would be better if it also tells the name of the site. So, include the company name as well in the alternative text.
- Also, since the logo is wrapped by a link there's no need to tell about what will happen to the users. The screen readers will pronounce it as a link. So, the users will know that it is going to navigate them to another web page.
- As a result the better alternative text is "officelite - home".
- The
details
andsummary
elements should not be used for custom select elements.- First, it won't be able to submit any information.
- Second, the screen reader will not pronounce it as a combobox. It tells the users that it is like an accordion element.
- I used Narrator and it pronounced it as "Basic Pack Free, button, collapsed." There's no way that the users know that it contains some options to choose from.
- I can't interact with the selection using the keyboard and the screen reader isn't pronouncing them correctly.
- To create an accessible combobox, I recommend taking at the Select-Only Combobox Example by W3C. You can either use third-party component for custom select or just use the native
select
element. - Consider using the right
type
for theinput
elements. For example, usetype="email"
for email input. This will help mobile users to get the right keyboard layout.
I hope this helps! Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord