Design comparison
Solution retrospective
I'm looking for any general feedback about where I can improve this project. More specifically, I can't figure out why I cant get the error or success messages to show for the email validation in the form. Thanks
Community feedback
- @Da-vi-dePosted over 3 years ago
Hi, nice result on this challenge, although it's not mobile first approach!
-
There's a typo in your HTML, the closing
main
tag misses /, also i'd recommend checking the report and try to resolve the issues. -
In JS you add the class
show
but in CSS that class hasdisplay: block
it should bedisplay: unset
because you setdisplay: none
toemail__error, email__success
but this isn't enough yet. First you need to remove the class in your else statement, you can't just add the class, you also need to remove it! And second either use anid
for selectingemailSuccess
andemailError
or different class, styled classes shouldn't be used for selectig.
Hope it helps, happy coding :-)
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord