Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

ntf-preview-card

@k-christelle

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Ecem Gokdogan 9,380

@ecemgo

Posted

Some recommendations regarding your code that could be of interest to you.

Each main content needs to start with an h1 element, and also contain only one h1 element. Your accessibility report states the need for one main landmark. So, in order to fix the accessibility issue, you need to use a <h1> element in the <main> tag instead of using <p>. You can replace your <p class="texte1">Equilibrium #3429</p> element with the <h1 class="texte1">Equilibrium #3429</h1> element.

Hope I am helpful. :)

0

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS ⚠️:

  • This solution had generated accessibility error report due to lack of level-one heading <h1>
  • Every site must want at least one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

0
Henoc 200

@henoceli3

Posted

Bonjour 👋. Bravo pour avoir relevé le défi !

Voici quelques suggestions concernant votre code qui pourraient vous intéresser.

HTML 🏷️ :

Pour effacer le rapport d'accessibilité :

Enveloppez tout le contenu principal de la page dans la <main>balise. Évitez toujours de sauter des niveaux de titre ; Commencer par <h1>les niveaux de titre ( <h2>, <h3>, etc.) permet de s'assurer que votre document a une hiérarchie claire et cohérente. Utilisez des éléments sémantiques HTML5 tels que <header>, <nav>, <main>, <aside>et <footer>pour définir ces sections. J'espère que vous le trouverez utile ! 😏 Surtout, la solution que vous avez soumise est 👌. 🎉Bon codage !

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord