Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NTF Preview Card Component

P

@hectorlil48

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All feedback is welcomed and helpful.

Community feedback

@faha1999

Posted

Hello, Hector Ramirez Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:

  • You might want to use semantic tags like the <footer> to wrap your code, instead of div. like
<footer class="attribution"></footer>

This would help improve accessibility.

  • add the below code to the body. It will center everything
body {
    justify-content: center;
    align-items: center;
    display: flex;
    min-height: 100vh;
    flex-direction: column;
}
  • remove margin from .container

  • Instead of using px, use relative units like rem or em to get better performance when the information on your page needs to be resized for multiple screens and devices. REM and EM apply to all sizes, not just font-size. You can code your entire page in px and then, at the very end, use the VsCode plugin px to rem to perform the automatic conversion px to rem

  • Fixed the other HTML error from the report.

  • this is my solution of this challenge live,repo

I hope it will work. Happy coding.

1

P

@hectorlil48

Posted

Hello, @faha1999 thanks for the feedback. The tips were helpful, I always get confused about when to use px or rem. I also get confused about when to use display flex to center things, instead of just using the margin to do it. I will keep theses tips in mind for further projects.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord