@faha1999
Posted
Hello, Hector Ramirez Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:
- You might want to use semantic tags like the
<footer>
to wrap your code, instead ofdiv
. like
<footer class="attribution"></footer>
This would help improve accessibility.
- add the below code to the body. It will center everything
body {
justify-content: center;
align-items: center;
display: flex;
min-height: 100vh;
flex-direction: column;
}
-
remove
margin
from.container
-
Instead of using
px
, use relative units likerem or em
to get better performance when the information on your page needs to be resized for multiple screens and devices.REM
andEM
apply to all sizes, not justfont-size
. You can code your entire page inpx
and then, at the very end, use the VsCode pluginpx to rem
to perform the automatic conversion px to rem -
Fixed the other
HTML
error from the report.
I hope it will work. Happy coding.
@hectorlil48
Posted
Hello, @faha1999 thanks for the feedback. The tips were helpful, I always get confused about when to use px or rem. I also get confused about when to use display flex to center things, instead of just using the margin to do it. I will keep theses tips in mind for further projects.