Design comparison
SolutionDesign
Community feedback
- @denieldenPosted almost 3 years ago
Hi Miguel, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - To make it look as close to the design as possible add
border-radius: 1rem;
tocard
class - set
width: 100%
toimg
tag - add
border-radius: 1rem; and overflow: hidden;
tocard-image
class
Overall you did well :)
Hope this help and happy coding!
Marked as helpful1 - add
- @RioCantrePosted almost 3 years ago
Hello there! Nice job in completing this project. Regarding your solution, I would like to recommend the following for you…
- Add the hover state of the design. For the hero image , refer it with this one Overlay in image. For the fonts, add
color: #00FFF7;
andcursor: pointer;
in.card .card-content .card-title h1
and.card .card-footer p span
rule sets - Add
border-radius: 10px;
in the.card
and.card .card-image img
rule sets - Add
border-radius: 50%;
andborder: 1px solid white;
on the.card .card-footer img
rule set - Wrap the whole content with specific tag like
main
. For HTML structures, refer it with this one Semantics
Above all, the project is done well. Keep up the good work and Hope this is helpful!
P.s. I bases the styling on the CSS file.
Marked as helpful1 - Add the hover state of the design. For the hero image , refer it with this one Overlay in image. For the fonts, add
- @optimusprime202Posted almost 3 years ago
Hey @MiguelHG2351, Keep working on it; you’re improving.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord