Notification page responsive, with animation on appear JS actions

Community feedback

• 

  Gregório Francisco•235

  @gregoriofrancisco99Posted almost 2 years ago

  Greetings, dear Dany, hope you're okay. Saw your solution and I've to say, I like the innovations you added to it. It gave the challenge a self look.

  Although, there's a few points that should make to solution way better than it's right now.

  • Header:

  1. You create a hard situation for yourself by creating a lot of sub-levels just to place the Mark all as read button. You should try to make your HTML document as clean as possible for yourself and for anyone reviewing or upgrading your code.
  2. You used an unordered list in a situation where it's not really need. You should solve it with a simple <a href=#>Mark all as read</a>. Learn more about <a>.

  • Horizontal row: should be used to separate context on your page and not to have visual effect, leave this to CSS. Click here to know more about <hr>.

  And remember... Keep coding 💻

  Marked as helpful

  0

  ---

  

  Dany el Cid•270

  @danyelcidPosted almost 2 years ago

  @gregoriofrancisco99 thank you for your review and your time i appreciated you pointed about de misuse of <hr> so i corrected it

  the levels for the Mark all as read button was a work in progress so i hope you like the update again thanks a lot

  1