Notifications page using vanilla JS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  JAVASCRIPT 🟡:

  • The way you declared variables are need to be well structured and organized

  ---

  • Take a look at the following example code which describes an efficient way of declaring variables

  const firstName = "Your";
  const lastName = "Name";
  const emailAddress = "[email protected]";
  const password = "supersecret";
  

  • instead try this,

  const firstName =  "Your",
         lastName =  "Name",
         emailAddress = "[email protected]"
         •••                
         •••         // n number of declarations
         password = "supersecret";   // make sure to add a semicolon at end of last declaration
  

  • This single line declaration with separated commas will helps you to have a better structured code and improves readability though

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Tohid Dalaei Milan•410

  @eng-milanPosted over 1 year ago

  Hi, nice looking page well done. If you could add functionality to unread notification that with click they will be marked as read, is a nice feature. What I mean is that not only clicking "Mark all as read" will make them read, but clicking each notification would mark it as read. This is what came to my mind at first glance.

  Marked as helpful

  0