Notifications page

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hello Carmen,

  great job with the challenge! Your solution looks good overall.

  The notification container seems to be too close to the top of the screen, so i'd suggest simply adding min-height: 100vh; to the body, so the body covers entire screen height and it ll automatically center on the page since u already use flexbox for that.

  Additionally, you can try to make it so that when users click on the unread notifications, they are updated/marked as read and so the counter changes as well. Optional but, perhaps when the count is 0, maybe no need to explicitly write zero, but only displaying count when there is at least one unread would make more sense.

  Hope you find this feedback helpful!

  Marked as helpful

  0

  ---

  

  Carmen•490

  @CarmenyoPosted over 1 year ago

  @visualdenniss Many thanks!!! I will do it!!

  0